Browse Source

Removed some comments

spesk1 5 years ago
parent
commit
4db794c424
2 changed files with 1 additions and 11 deletions
  1. 1 3
      README.md
  2. 0 8
      lib/SimplyGit/Git.pm

+ 1 - 3
README.md

@@ -6,9 +6,7 @@ Mainly writing to learn more about Git and Perl, unlikely to be widely useful.
 TODO:
 
 Features:
-
---branch-from-upstream
-* generate an up to date new branch from upstream/master
+No more ideas. Open to suggestions.
 
 Stuff to fix:
 * multipule TODO:'s in various files

+ 0 - 8
lib/SimplyGit/Git.pm

@@ -7,9 +7,6 @@ use SimplyGit::Shellex qw(shellex findBin);
 use Exporter qw(import);
 our @EXPORT_OK = qw(readConfig getStatus returnState addFiles commitChanges pushChanges stashAndReset resetFromUpstream updateGitIgnore appendRepoUserConfig);
 
-# TODO: Handle "optional" passing of logger object
-# Need to identify which subs are called before the logger object is initialized ( if any )
-# and then required the logger object arg for all who don't fit that usecase
 # TODO: Add info/debug logging for all subroutines
 
 sub checkPath($$) {
@@ -62,7 +59,6 @@ sub readConfig($$) {
 	# Tag each line with it's heading
 	# Only way I could think of that worked to solve how this
 	# There are almost certainly better ways
-	# TODO
 	my @taggedLines;
 	my $tag = "NULLTAG";
 	foreach my $line ( @configLines ) {
@@ -154,8 +150,6 @@ sub addFiles($$) {
 
 }
 
-# TODO: Possibly worth returning output for commitChanges(), pushChanges(), stashAndReset, even if I'm not using it right now
-
 sub commitChanges($$) {
 
 	my $commitMsg = shift;
@@ -197,7 +191,6 @@ sub stashAndReset($) {
 	my $gitCmd = findBin("git",$logger);
 	shellex("$gitCmd stash",$logger);
 	dropStash($logger);
-	# TODO: Depending on use case need to do more here
 	shellex("$gitCmd rebase",$logger);
 }
 
@@ -234,7 +227,6 @@ sub updateGitIgnore($$$) {
 		my $catCmd = findBin("cat",$logger);
 		my @ignoreLines = split("\n",shellex("$catCmd $filename",$logger));
 		if ( ! grep( /^$ignoreValue$/, @ignoreLines ) ) {
-			# TODO: What if logger object is not passed in?
 			open(my $fh, ">>", $filename) or die $logger->error("Couldn't open $filename, exiting...");
 			chomp $ignoreValue;
 			print $fh "$ignoreValue\n";